[webkit-reviews] review granted: [Bug 129398] Prepare for overflow scrolling nodes in the scrolling tree : [Attachment 225320] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129398: Prepare for overflow scrolling nodes in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=129398

Attachment 225320: Patch
https://bugs.webkit.org/attachment.cgi?id=225320&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225320&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:3493
> +	   else
> +	       ASSERT_NOT_REACHED();

I think you want curly braces here

> Source/WebCore/rendering/RenderLayerCompositor.h:408
> +	   FixedOrSticky = 1 << 0,

ViewportConstrained? :D