[webkit-reviews] review granted: [Bug 129400] Give VisitedLinkProviders an identifier and send them to the web process : [Attachment 225308] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 129400: Give VisitedLinkProviders an identifier and send them to the web
process
https://bugs.webkit.org/show_bug.cgi?id=129400

Attachment 225308: Patch
https://bugs.webkit.org/attachment.cgi?id=225308&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225308&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h:37
> +    RefPtr<WebKit::VisitedLinkProvider> _visitedLinkProvider;

Please keep this ivar in the implementation file until there’s a reason to
expose it (and then use @package).

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:44
> +    static uint64_t identifier;
> +
> +    return ++identifier;

Since clients can call -[WKVisitedLinkProvider init] from any thread, this
needs to be made thread-safe.