[webkit-reviews] review granted: [Bug 129339] Pipe experimental image controls menu up to WebKit2 : [Attachment 225249] Patch v6 - Build fixes

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 129339: Pipe experimental image controls menu up to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=129339

Attachment 225249: Patch v6 - Build fixes
https://bugs.webkit.org/attachment.cgi?id=225249&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225249&action=review


> Source/WebCore/ChangeLog:8
> +	   Handle events for the image control starting the context menu
process if appropriate:

"context menu process" confused me

> Source/WebCore/page/ContextMenuContext.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/WebCore/page/ContextMenuContext.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/WebCore/page/ContextMenuContext.h:39
> +    ContextMenuContext(const HitTestResult&, bool isImageControl = false);

If we end up adding lots of stuff to ContextMenuContext, this isImageControl
param doesn't seem like a good start for extensibility.

> Source/WebKit2/Shared/ContextMenuContextData.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014