[webkit-reviews] review granted: [Bug 128175] REGRESSION(r162947): Document::topDocument() returns an incorrect reference for cached Documents : [Attachment 224001] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128175: REGRESSION(r162947): Document::topDocument() returns an incorrect
reference for cached Documents
https://bugs.webkit.org/show_bug.cgi?id=128175

Attachment 224001: Patch
https://bugs.webkit.org/attachment.cgi?id=224001&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=224001&action=review


Ok, lets land this while we figure out a real fix.

> Source/WebCore/dom/Document.cpp:4251
> +    if (!m_inPageCache && !m_renderTreeBeingDestroyed) {

Please add a FIXME here indicating that this is a workaround for AX teardown
problem.