[webkit-reviews] review denied: [Bug 23053] LI element loses its bullet in multi-column mode : [Attachment 224470] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 26 09:07:04 PST 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has denied gur.trio at gmail.com's
request for review:
Bug 23053: LI element loses its bullet in multi-column mode
https://bugs.webkit.org/show_bug.cgi?id=23053
Attachment 224470: Patch
https://bugs.webkit.org/attachment.cgi?id=224470&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224470&action=review
> Source/WebCore/rendering/RenderListMarker.cpp:1741
> - return m_listItem.notInList() || style().listStylePosition() == INSIDE;
> + return m_listItem.notInList() || style().listStylePosition() == INSIDE
|| m_listItem.parent()->hasColumns();
This doesn't seem like the correct way to fix this.
More information about the webkit-reviews
mailing list