[webkit-reviews] review granted: [Bug 129361] Avoid unnecessary HTML Collection invalidations for id and name attribute changes : [Attachment 225218] Fixes the bug

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 129361: Avoid unnecessary HTML Collection invalidations for id and name
attribute changes
https://bugs.webkit.org/show_bug.cgi?id=129361

Attachment 225218: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=225218&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225218&action=review


> Source/WebCore/dom/NodeRareData.h:233
> +	   for (auto it = m_atomicNameCaches.begin(), end =
m_atomicNameCaches.end(); it != end; ++it) {

You  could use a for-each loop here and in the following loops.

> Source/WebCore/dom/NodeRareData.h:237
> +	       list.invalidateCache(0);

Shouldn't you just call list.invalidateCache() here?