[webkit-reviews] review requested: [Bug 128766] Web Inspector: CRASH when evaluating in console of JSContext RWI with disabled breakpoints : [Attachment 225205] patch 3: require ordered re-entry into the VM

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 128766: Web Inspector: CRASH when evaluating in console of JSContext RWI
with disabled breakpoints
https://bugs.webkit.org/show_bug.cgi?id=128766

Attachment 225205: patch 3: require ordered re-entry into the VM
https://bugs.webkit.org/attachment.cgi?id=225205&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I talked with Geoff offline, and we decided to switch tactics.	Instead of
continuing with allowing unordered re-entry into the VM, we're switching to
requiring ordered re-entry (which is how we used to roll back in the day i.e. a
few weeks ago).  This means making JSLock::grabAllLocks() work the same way it
does for the C loop LLINT.  We currently cannot think of any clients (or
potential clients) that would require and significantly benefit from ordered
re-entry.  Hence, we're moving forward with the simplest solution of just
making JSLock::grabAllLocks() ordered.