[webkit-reviews] review granted: [Bug 129278] [Win] Gracefully recover from missing "naturalSize" parameter for media : [Attachment 225121] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 129278: [Win] Gracefully recover from missing "naturalSize" parameter for
media
https://bugs.webkit.org/show_bug.cgi?id=129278

Attachment 225121: Patch
https://bugs.webkit.org/attachment.cgi?id=225121&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225121&action=review


>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:758
> +		   // Don't treat a failure to retrieve these parameters as
fatal. We will use @"presentationSize" instead.
> +		   // <rdar://problem/15966685>

This comment (and the change log) imply that
MediaCharacteristicsWithMediaSelectionOptions is equivalent to NaturalSize.
This is seems unlikely. Having separate comparisons for each, with a comment
about why it is OK to fail to retrieve
MediaCharacteristicsWithMediaSelectionOptions, would be better.

>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:904
>	       if (AVCFPlayerItemTrackIsEnabled(track)) {
>		   RetainPtr<AVCFAssetTrackRef> assetTrack =
adoptCF(AVCFPlayerItemTrackCopyAssetTrack(track));
> +		   if (!assetTrack)
> +		       continue;

This seems odd, please add a comment about why we don't care that a track is
enabled but not available.