[webkit-reviews] review granted: [Bug 129304] Inspector server should be enabled only when the web sockets is enabled too. : [Attachment 225144] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 25 06:51:31 PST 2014
Csaba Osztrogonác <ossy at webkit.org> has granted Gergő Balogh
<gbalogh.u-szeged at partner.samsung.com>'s request for review:
Bug 129304: Inspector server should be enabled only when the web sockets is
enabled too.
https://bugs.webkit.org/show_bug.cgi?id=129304
Attachment 225144: patch
https://bugs.webkit.org/attachment.cgi?id=225144&action=review
------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225144&action=review
The fix LGTM, but please fix the changelog.
> Source/WebKit2/ChangeLog:3
> + Inspector should be enabled only when the web sockets is enabled
too.
You meant "Inspector _server_ should be enabled only when the web sockets is
enabled too."
More information about the webkit-reviews
mailing list