[webkit-reviews] review granted: [Bug 129299] [New Multicolumn] -webkit-column-break-inside:avoid doesn't work : [Attachment 225139] Patch

[bugzilla-daemon at webkit.org]

Andrei Bucur <abucur at adobe.com> has granted Morten Stenshorne
<mstensho at opera.com>'s request for review:
Bug 129299: [New Multicolumn] -webkit-column-break-inside:avoid doesn't work
https://bugs.webkit.org/show_bug.cgi?id=129299

Attachment 225139: Patch
https://bugs.webkit.org/attachment.cgi?id=225139&action=review

------- Additional Comments from Andrei Bucur <abucur at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225139&action=review


r=me with some nits.

> Source/WebCore/ChangeLog:7
> +

Please add a short textual description of what the patch does.

> Source/WebCore/rendering/RenderBlockFlow.cpp:1696
> +    bool isInsideMulticolFlowThread = flowThread &&
!flowThread->isRenderNamedFlowThread();

In RenderLayer::updatePagination() the check for a multi-column flow thread is
RenderObject::isInFlowRenderFlowThread(). I think it makes sense to use it here
as well.