[webkit-reviews] review granted: [Bug 129146] WebKit2 View Gestures (Smart Magnification): Support for iOS : [Attachment 224904] zomgrebase

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 129146: WebKit2 View Gestures (Smart Magnification): Support for iOS
https://bugs.webkit.org/show_bug.cgi?id=129146

Attachment 224904: zomgrebase
https://bugs.webkit.org/attachment.cgi?id=224904&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224904&action=review


> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:330
> +    [_interactionView _setDoubleTapGestureRecognizer:recognizer];

Nope!

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:137
> +    toImpl([_contentView
_pageRef])->setShouldRecordNavigationSnapshots(allowsBackForwardNavigationGestu
res);

Space after [. This is now [_contentView page]->

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:262
> +    WebPageProxy *webPageProxy = toImpl([_contentView _pageRef]);

Changed.

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:265
> +    UIGestureRecognizer *recognizer =
_gestureController->installSmartMagnificationHandler(_contentView.get(),
_scrollView.get());

Odd that we call it magnification not zoom.

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:164
> +    RetainPtr<WKSmartMagnificationGestureController>
m_smartMagnificationGestureController;
> +    RetainPtr<UIScrollView> m_smartMagnificationScrollView;
> +    RetainPtr<UIView> m_smartMagnificationTargetView;

Who owns the gesture controller? Are we creating ref cycles here?