[webkit-reviews] review granted: [Bug 129276] Use RetainPtrs for two WKContentView data members : [Attachment 225109] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129276: Use RetainPtrs for two WKContentView data members
https://bugs.webkit.org/show_bug.cgi?id=129276

Attachment 225109: Patch
https://bugs.webkit.org/attachment.cgi?id=225109&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225109&action=review


> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:113
>  @property (nonatomic, readonly) BOOL isEditable;
> + at property (readonly, nonatomic) const
WebKit::InteractionInformationAtPosition& positionInformation;
> + at property (readonly, nonatomic) const WebKit::WKAutoCorrectionData&
autocorrectionData;

Switch nonatomic and readonly here for consistency?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:188
> +    [_formAccessoryView release];

_formAccessoryView = nil;