[webkit-reviews] review granted: [Bug 128564] WK2 AVKit fullscreen doesn't display video. : [Attachment 225081] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 24 16:06:33 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128564: WK2 AVKit fullscreen doesn't display video.
https://bugs.webkit.org/show_bug.cgi?id=128564

Attachment 225081: Patch
https://bugs.webkit.org/attachment.cgi?id=225081&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225081&action=review


> Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h:81
> +    bool m_sendUnparentVideoLayerTransaction;

Hard to parse. And you don't really send a transaction, you set a flag as part
of one.


More information about the webkit-reviews mailing list