[webkit-reviews] review granted: [Bug 129260] Web Inspector: Toolbar is all white on non-Mac platforms : [Attachment 225076] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 24 11:48:36 PST 2014
Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 129260: Web Inspector: Toolbar is all white on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=129260
Attachment 225076: Patch
https://bugs.webkit.org/attachment.cgi?id=225076&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review
r=me
> Source/WebInspectorUI/UserInterface/Base/Main.js:203
> + } else if (navigator.platform.contains("Win"))
> + document.body.classList.add("windows-platform");
> + else if (navigator.platform.contains("Linux"))
> + document.body.classList.add("linux-platform");
> + else
> + document.body.classList.add("other-platform");
Should we use InspectorFrontendHost.platform instead? It would simplify things
a bit.
More information about the webkit-reviews
mailing list