[webkit-reviews] review granted: [Bug 129210] FTL should do polymorphic PutById inlining : [Attachment 225073] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129210: FTL should do polymorphic PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=129210

Attachment 225073: the patch
https://bugs.webkit.org/attachment.cgi?id=225073&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225073&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1969
> +	   if (!isFTL(m_graph.m_plan.mode)) {
> +	       emitPutById(base, identifierNumber, value, isDirect);
> +	       return;
> +	   }

We will need to support polymorphic put_by_id in the DFG (and baseline, and
possibly even the interpreter) to make caching of DOM setters actually useful.