[webkit-reviews] review requested: [Bug 129106] [GTK] Regression when showing the captions menu : [Attachment 225048] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 24 02:39:09 PST 2014


Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 129106: [GTK] Regression when showing the captions menu
https://bugs.webkit.org/show_bug.cgi?id=129106

Attachment 225048: Patch
https://bugs.webkit.org/attachment.cgi?id=225048&action=review

------- Additional Comments from Xabier Rodríguez Calvar <calvaris at igalia.com>
I removed the test and added that part of the code to one of the tests. The
problem is that all trackmenu tests are flagged in Mac and GTK+, so this
regression won't be properly tested unless we go for the other version with the
complete test, which I think it is not bad idea because at lest a very basic
functionaly of the menu is tested.


More information about the webkit-reviews mailing list