[webkit-reviews] review granted: [Bug 128417] [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files : [Attachment 224801] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 128417: [GTK] generate-gtkdoc should not generate documentation for source
files for unbuilt source files
https://bugs.webkit.org/show_bug.cgi?id=128417

Attachment 224801: Patch
https://bugs.webkit.org/attachment.cgi?id=224801&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224801&action=review


> Tools/gtk/GNUmakefile.am:13
> -docs_build_stamp_list = \
> +docs_build_dependencies = \

Why renaming this? looks unrelated

> Tools/gtk/generate-gtkdoc:88
> +	   header_parts = os.path.splitext(header)
> +	   add_file_if_exists(header_parts[0] + ".cpp")
> +	   add_file_if_exists(header_parts[0] + ".c")

You could get the basename without the extension directly, and avoid using [0].


basename = os.path.splitext(header)[0]

> Tools/gtk/generate-gtkdoc:123
> +	   'cflags': " ".join(config.get(module_name, 'cflags').split()),

Why do you split and then join?