[webkit-reviews] review granted: [Bug 129154] An element having -webkit-mix-blend mode should only blend with the contents of the parent stacking context : [Attachment 224877] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 129154: An element having -webkit-mix-blend mode should only blend with the
contents of the parent stacking context
https://bugs.webkit.org/show_bug.cgi?id=129154

Attachment 224877: Patch V1
https://bugs.webkit.org/attachment.cgi?id=224877&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224877&action=review


> Source/WebCore/ChangeLog:9
> +	   This change isolates blending, preventing it to blend with other
underlying elements besides the parent stacking context.

Typo "to" -> "from"

> Source/WebCore/rendering/RenderLayer.cpp:814
> +    if (!oldStyle && renderer().style().hasBlendMode())
> +	   m_updateParentStackingContextShouldIsolateBlendingDirty = true;
> +
> +    if (oldStyle && oldStyle->hasBlendMode() !=
renderer().style().hasBlendMode())
> +	   m_updateParentStackingContextShouldIsolateBlendingDirty = true;

Make this one test, even though it will be long.

> Source/WebCore/rendering/RenderLayer.h:785
>  #if ENABLE(CSS_COMPOSITING)
>      bool hasBlendMode() const { return renderer().hasBlendMode(); }
> +    bool isolatesBlending() const { return m_isolatesBlending; }
>  #else
>      bool hasBlendMode() const { return false; }
> +    bool isolatesBlending() const { return false; }
>  #endif

I think it would be better to write these the other way around:

bool isolatesBlending() const
{
#if ENABLE(CSS_COMPOSITING)
  return m_isolatesBlending;
#else
  return false;
#endif
}


Same for hasBlendMode