[webkit-reviews] review granted: [Bug 126842] Only skip stretchy operators when determining the stretch height : [Attachment 224846] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Frédéric Wang
<fred.wang at free.fr>'s request for review:
Bug 126842: Only skip stretchy operators when determining the stretch height
https://bugs.webkit.org/show_bug.cgi?id=126842

Attachment 224846: Patch
https://bugs.webkit.org/attachment.cgi?id=224846&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224846&action=review


> Source/WebCore/ChangeLog:8
> +	   The MathML code only takes into account non-mo children for the
computation of the stretch size. Thus change includes non-stretchy mo in that
computation. A new test is added into
mathml/presentation/stretchy-depth-height.html.

thus -> this

> Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:65
> +	       // We exclude stretchy operators from the computation of the
stretch size.

I would add the why you're skipping stretchy operators to the comment here as
well.