[webkit-reviews] review granted: [Bug 124827] Implement asymmetric/symmetric stretching of vertical operators : [Attachment 224859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 21 23:25:02 PST 2014


chris fleizach <cfleizach at apple.com> has granted Frédéric Wang
<fred.wang at free.fr>'s request for review:
Bug 124827: Implement asymmetric/symmetric stretching of vertical operators
https://bugs.webkit.org/show_bug.cgi?id=124827

Attachment 224859: Patch
https://bugs.webkit.org/attachment.cgi?id=224859&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224859&action=review


> LayoutTests/mathml/presentation/stretchy-depth-height-symmetric.html:11
> +	   return Math.abs(x - y) < epsilon;

indendation levels should be +4 spaces

> Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1266
> +	   // FIXME: We should read the read the axis from the MATH table
(https://bugs.webkit.org/show_bug.cgi?id=122297). For now, we use the same
value as in RenderMathMLFraction::firstLineBaseline().

too many words ---"should read the read the"


More information about the webkit-reviews mailing list