[webkit-reviews] review granted: [Bug 129195] REGRESSION(r164412): Pixel cracks when zooming in to any web content. : [Attachment 224946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 21 22:20:54 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 129195: REGRESSION(r164412): Pixel cracks when zooming in to any web
content.
https://bugs.webkit.org/show_bug.cgi?id=129195

Attachment 224946: Patch
https://bugs.webkit.org/attachment.cgi?id=224946&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:2243
> +    LayoutRect dirtyRect(enclosingIntRect(clip));
>      IntRect pixelSnappedRectForIntegralPositionedItems =
pixelSnappedIntRect(dirtyRect);

Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect().
Should it be an IntRect?


More information about the webkit-reviews mailing list