[webkit-reviews] review denied: [Bug 128936] text-decoration-skip: ink does not skip over SVG fonts : [Attachment 224437] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 21 18:32:25 PST 2014


Dean Jackson <dino at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 128936: text-decoration-skip: ink does not skip over SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=128936

Attachment 224437: Patch
https://bugs.webkit.org/attachment.cgi?id=224437&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224437&action=review


> Source/WebCore/ChangeLog:15
> +	   Tests:
fast/css3-text/css3-text-decoration/text-decoration-skip/helvetica.svg

We definitely can't upload a copyrighted font as a test. You'll have to hand
author something that has descenders. On the plus side, you could author
something that makes the ref test really easy.


More information about the webkit-reviews mailing list