[webkit-reviews] review denied: [Bug 129181] Auto generate bytecode information for bytecode parser and LLInt : [Attachment 224922] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 129181: Auto generate bytecode information for bytecode parser and LLInt
https://bugs.webkit.org/show_bug.cgi?id=129181

Attachment 224922: Patch
https://bugs.webkit.org/attachment.cgi?id=224922&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Please also do a C loop build and ensure that it does build and run.  We now
have a LLINT C Loop build and test bot.  So, we need to keep that green.

I was thinking that you can also remove FOR_EACH_LLINT_OPCODE_EXTENTION and
therefore LLIntOpcode.h.  However, when I  took a look at LLIntOpcode.h, I saw
synthetic llint_cloop_did_return_from_js_X opcodes which tells me that I don't
think you can remove FOR_EACH_LLINT_OPCODE_EXTENTION.  This also means that you
can't remove the distinction between FOR_EACH_OPCODE_ID and
FOR_EACH_CORE_OPCODE_ID.

If you do a C loop LLINT build, you should be able to resolve what you can and
cannot do here.