[webkit-reviews] review granted: [Bug 129164] Make a generic CDMPrivateMediaPlayer and move its CDMSession into platform/. : [Attachment 224897] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129164: Make a generic CDMPrivateMediaPlayer and move its CDMSession into
platform/.
https://bugs.webkit.org/show_bug.cgi?id=129164

Attachment 224897: Patch
https://bugs.webkit.org/attachment.cgi?id=224897&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224897&action=review


> Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:2
> + * Copyright (C) 2012 Apple Inc. All rights reserved.

Nit: you might as well update this.

> Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.h:2
> + * Copyright (C) 2012 Apple Inc. All rights reserved.

Ditto.

> Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.h:41
> +    // CDMFactory support:

Nit: this isn't terribly informative.

> Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.h:42
> +    static PassOwnPtr<CDMPrivateInterface> create(CDM* cdm) { return
adoptPtr(new CDMPrivateMediaPlayer(cdm)); }

Can be converted to std::unique_ptr as well?

> Source/WebCore/platform/graphics/CDMSession.h:2
> + * Copyright (C) 2013]4 Apple Inc. All rights reserved.

2013]4 - when was/is :-) ?

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.m
m:49
> +
> +

Nit: extra blank line.

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.m
m:66
> +	   return 0;

nullptr.

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.m
m:84
> +	   return 0;

Ditto.

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.m
m:89
> +    errorCode = MediaPlayer::NoError;
> +    systemCode = 0;
> +    destinationURL = String();

These don't seem to be used.

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.m
m:106
> +    errorCode = MediaPlayer::NoError;
> +    systemCode = 0;
> +    nextMessage = nullptr;

Ditto.