[webkit-reviews] review granted: [Bug 129161] Add a supportsKeySystem media engine factory parameter. : [Attachment 224891] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129161: Add a supportsKeySystem media engine factory parameter.
https://bugs.webkit.org/show_bug.cgi?id=129161

Attachment 224891: Patch
https://bugs.webkit.org/attachment.cgi?id=224891&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224891&action=review


If the registrar took a MediaPlayerFactory instead of a bunch of function
pointers, we could add new factory methods without touching ports that don't
implement them. 

r=me either way.

> Source/WebCore/platform/graphics/MediaPlayer.cpp:1020
> +    unsigned size = engines.size();
> +    for (unsigned i = 0; i < size; i++) {
> +	   if (engines[i]->supportsKeySystem &&
engines[i]->supportsKeySystem(keySystem, mimeType))
> +	       return true;
> +    }

Can this use a range-based loop?