[webkit-reviews] review denied: [Bug 128564] WK2 AVKit fullscreen doesn't display video. : [Attachment 224885] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128564: WK2 AVKit fullscreen doesn't display video.
https://bugs.webkit.org/show_bug.cgi?id=128564

Attachment 224885: Patch
https://bugs.webkit.org/attachment.cgi?id=224885&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224885&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:212
> + at property (nonatomic, readwrite, getter = isReadyForDisplay) BOOL
readyForDisplay;
> + at property (nonatomic, readwrite) CGRect videoRect;

No need to specify readwrite

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:190
> +    Vector<WebCore::GraphicsLayer::PlatformLayerID>
m_videoLayerIDsPendingFullscreen;

HashSet?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:68
> +    [m_platformLayer setValue:[NSValue valueWithPointer:nil]
forKey:platformCALayerPointer];

setValue:nil?

> Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.cpp:114
> +    m_platformCALayer = PlatformCALayer::platformCALayer(videoLayer);

Should this use ::create()?