[webkit-reviews] review granted: [Bug 129129] DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints : [Attachment 224809] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129129: DFG should do its own static estimates of execution frequency
before it starts creating OSR entrypoints
https://bugs.webkit.org/show_bug.cgi?id=129129

Attachment 224809: the patch
https://bugs.webkit.org/attachment.cgi?id=224809&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224809&action=review


r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   This is better than letting LLVM do its own static estimates, since
by the time we
> +	   generate LLVM IR, we may have messed up the CFG due to OSR
entrypoint creation. Of
> +	   course, it would be even better if we just slurped in some kind of
execution counts
> +	   from profiling, but we don't do that, yet.

Do want.