[webkit-reviews] review granted: [Bug 129126] Move the image controls setting to Settings.in : [Attachment 224807] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 16:11:22 PST 2014


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 129126: Move the image controls setting to Settings.in
https://bugs.webkit.org/show_bug.cgi?id=129126

Attachment 224807: Patch v1
https://bugs.webkit.org/attachment.cgi?id=224807&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224807&action=review


> Source/WebCore/page/Settings.h:-242
> -    bool imageControlsEnabled() { return m_imageControlsEnabled; }

do you still need the member and its initializer? I don't see them for other
Settings.in settings...


More information about the webkit-reviews mailing list