[webkit-reviews] review granted: [Bug 129059] WKInteractionView always blocks the main thread when sending touch events : [Attachment 224670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 15:41:00 PST 2014


Enrica Casucci <enrica at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 129059: WKInteractionView always blocks the main thread when sending touch
events
https://bugs.webkit.org/show_bug.cgi?id=129059

Attachment 224670: Patch
https://bugs.webkit.org/attachment.cgi?id=224670&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224670&action=review


Looks good to me.

> Source/WebKit2/ChangeLog:3
> +	   WKInteractionView always block the main thread when sending touch
events

typo blocks

> Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm:152
> +    unsigned _nativeWebTouchEventUniqueIdBeingSendSynchronously;

I think the name should be _nativeWebTouchEventUniqueIdBeingSentSynchronously


More information about the webkit-reviews mailing list