[webkit-reviews] review requested: [Bug 129111] Get rid of the unused 'immediate' parameters from repaint related functions : [Attachment 224803] Proposed patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <rhodovan.u-szeged at partner.samsung.com> has asked  for review:
Bug 129111: Get rid of the unused 'immediate' parameters from repaint related
functions
https://bugs.webkit.org/show_bug.cgi?id=129111

Attachment 224803: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=224803&action=review

------- Additional Comments from Renata Hodovan
<rhodovan.u-szeged at partner.samsung.com>
@simon.fraser: thank you for the review. Unfortunately, the mac and wk2 builds
failed after you set the r+ flag. To make sure I don't mess up the build of any
ports, I upload an updated patch again.
In the update, there were two 'non-trivial' modifications.
WebChromeClient::invalidateRootView() does depend on the immediate argument and
ScrollView::scrollContents() calls it both ways. The other case is
WebChromeClient::invalidateRootView() which is almost always called with
immediate set to false, but ScrollView::paintOverhangAreas() and
ScrollView::removePanScrollIcon() call it with true. In this patch I considered
it as false and eliminated the related code. However, I'm not familiar with
these ports, so I'd like to ask for a second round of review. :)