[webkit-reviews] review granted: [Bug 129110] An unresolved WebGL Context should operate normally until used : [Attachment 224795] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 129110: An unresolved WebGL Context should operate normally until used
https://bugs.webkit.org/show_bug.cgi?id=129110

Attachment 224795: Patch
https://bugs.webkit.org/attachment.cgi?id=224795&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224795&action=review


The only thing I don't get here is how do we decide we are in a pending state?
Does webGLPolicyForURL do something clever?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:410
> +

Extra blank line!

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3313
> +	   // FIXME: We don't currently do anything with the result from
resolution. A more

Should we have a bug filed here so we don't forget about it?

> Source/WebCore/html/canvas/WebGLRenderingContext.h:342
> +    WebGLRenderingContext(HTMLCanvasElement*,
GraphicsContext3D::Attributes);

Should this special constructor be private to prevent unintentional use of it
outside of the "pending" use case?