[webkit-reviews] review granted: [Bug 129117] Add magnification and swiping properties to WKWebView : [Attachment 224793] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 129117: Add magnification and swiping properties to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=129117

Attachment 224793: patch
https://bugs.webkit.org/attachment.cgi?id=224793&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224793&action=review


r=me if you address the comments.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:126
> + at property (nonatomic) double magnification;

This should be a CGFloat.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:128
> +- (void)setMagnification:(double)magnification
centeredAtPoint:(NSPoint)point;

magnification should be a CGFloat.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:470
> +- (void)setMagnification:(double)magnification
> +{
> +    [_wkView setMagnification:magnification];
> +}

Who uses this? And how?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:669
> +    } else
> +	   _gestureController = nullptr;

This branch is taken when allowsBackForwardNavigationGestures is YES and
_gestureController is not null. I don’t think you want to do that.