[webkit-reviews] review denied: [Bug 129051] GetMyArgumentsByLength in FTL doesn't work with inline code : [Attachment 224654] Fixed GetMyArgumentsLength in FTL to work with inline code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 13:56:35 PST 2014


Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 129051: GetMyArgumentsByLength in FTL doesn't work with inline code
https://bugs.webkit.org/show_bug.cgi?id=129051

Attachment 224654: Fixed GetMyArgumentsLength in FTL to work with inline code
https://bugs.webkit.org/attachment.cgi?id=224654&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Actually, this test is broken.	There's no way it even hits the FTL since it
relies on global code.	Did you test the test?	It's very important that when
you add a test, you check that it indeed reproduces the bug you're trying to
fix.  I don't buy that this test gives us coverage over the old version of this
code.


More information about the webkit-reviews mailing list