[webkit-reviews] review denied: [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand : [Attachment 224747] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Płóciennik
<r.plociennik at samsung.com>'s request for review:
Bug 129098: WebKit crashes during execution of ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=129098

Attachment 224747: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=224747&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224747&action=review


> Source/WebCore/ChangeLog:12
> +	   Editing commands executed during
> +	   ReplaceSelectionCommand::moveNodeOutOfAncestor() (utilized by
> +	   makeInsertedContentRoundTrippableWithHTMLTreeBuilder and responsible
for
> +	   moving prohibited children out of their ancestors) are not applied
> +	   properly when attempting to modify a non-editable element.

We should never be modifying non-editable element.
That's what we need to fix.
We shouldn't be working-around our bugs like this by ignoring contenteditable
value.
r-.