[webkit-reviews] review granted: [Bug 119686] Web Inspector: rich editing of CSS gradients : [Attachment 224777] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 119686: Web Inspector: rich editing of CSS gradients
https://bugs.webkit.org/show_bug.cgi?id=119686

Attachment 224777: Patch
https://bugs.webkit.org/attachment.cgi?id=224777&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224777&action=review


>
Source/WebInspectorUI/UserInterface/CodeMirrorGradientEditingController.js:177
> +	   var matches = this._angleInput.value.match(/º/g);

Should unicode escape the symbol.

>
Source/WebInspectorUI/UserInterface/CodeMirrorGradientEditingController.js:180
> +	       this._angleInput.value = angle + "º";

Ditto.

>
Source/WebInspectorUI/UserInterface/CodeMirrorGradientEditingController.js:192
> +		   this._angleInput.value = "180º";

Ditto.

> Source/WebInspectorUI/UserInterface/GradientSlider.css:103
> +    border: 1px solid rgba(0,0,0,0.25);

Spaces after the commas.

> Source/WebInspectorUI/UserInterface/GradientSlider.js:357
> +	   if (selected)
> +	      
this._element.classList.add(WebInspector.GradientSliderKnob.SelectedClassName);

> +	   else
> +	      
this._element.classList.remove(WebInspector.GradientSliderKnob.SelectedClassNam
e);

This can be one line:
this._element.classList.toggle(WebInspector.GradientSliderKnob.SelectedClassNam
e, selected);

> Source/WebInspectorUI/UserInterface/Images/Checkers.svg:2
> +<svg xmlns="http://www.w3.org/2000/svg" width="6" height="6" fill="rgb(204,
204, 204)"><rect width="3" height="3" /><rect x="3" y="3" width="3"
height="3"/></svg>
>  \ No newline at end of file

This should get the license header comment and have newlines.