[webkit-reviews] review granted: [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects : [Attachment 224749] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 128422: Web Inspector: update check-webkit-style to flag single quotes in
WebInspectorUI projects
https://bugs.webkit.org/show_bug.cgi?id=128422

Attachment 224749: Patch
https://bugs.webkit.org/attachment.cgi?id=224749&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224749&action=review


r=me! I like this much better! Thanks for looking into it again.

> Tools/Scripts/webkitpy/style/checkers/js.py:75
> +	       # Remove strings

Nit: Remove "double quoted" strings.

> Tools/Scripts/webkitpy/style/checkers/js.py:76
> +	       line = re.compile(r'"(?:[^"\\]|\\.)*"', re.MULTILINE).sub('""',
line)

Nit: I don't think you need re.MULTILINE. The input string (line) is only a
single line anyways right?

> Tools/Scripts/webkitpy/style/checkers/js.py:78
> +	       # Remove single line comment if any

Nit: Comment should be full sentences that end in a period. That applies to all
these # comments.

> Tools/Scripts/webkitpy/style/checkers/js.py:88
> +	       line = re.compile('/.+?/', re.MULTILINE).sub('//', line)

Ditto regarding MULTILINE.