[webkit-reviews] review denied: [Bug 128092] Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole : [Attachment 224720] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Gergő Balogh
<gbalogh.u-szeged at partner.samsung.com>'s request for review:
Bug 128092: Web Inspector: RuntimeManager should not use view object
WebInspector.quickConsole
https://bugs.webkit.org/show_bug.cgi?id=128092

Attachment 224720: patch
https://bugs.webkit.org/attachment.cgi?id=224720&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224720&action=review


> Source/WebInspectorUI/UserInterface/RuntimeManager.js:76
> +	   if (!contextId) {
> +	       contextId =
WebInspector.quickConsole.executionContextIdentifier;
> +	   }

Passing in the contextId (preferably contextIdentifier) is the right approach.

The idea of this bug was to remove the use of WebInspector.quickConsole
altogether, not just hide it behind an optional argument.

I also don't see where anyone is passing a context to evaluateInInspectedWindow
in this patch, so nothing has really changed.