[webkit-reviews] review granted: [Bug 129081] ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions : [Attachment 224705] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 129081: ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=129081

Attachment 224705: Patch
https://bugs.webkit.org/attachment.cgi?id=224705&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This breaks gcc build. I think that we need an ASSERT_NOT_REACHED() and return
at the end.

/mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp: In member
function 'bool WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions(const
WTF::String&, const WebCore::URL&, long unsigned int)':
/mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp:3074:1: error:
control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors