[webkit-reviews] review granted: [Bug 129083] DFG should have a way of carrying and preserving conditional branch weights : [Attachment 224714] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 22:40:47 PST 2014


Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129083: DFG should have a way of carrying and preserving conditional branch
weights
https://bugs.webkit.org/show_bug.cgi?id=129083

Attachment 224714: the patch
https://bugs.webkit.org/attachment.cgi?id=224714&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224714&action=review


r=me
Do all the other files have updated copyright (adding , 2014)?	If not, add
them.

> Source/JavaScriptCore/dfg/DFGNode.cpp:44
> +    if (count == count)

Is this checking !NaN?	A comment would help.


More information about the webkit-reviews mailing list