[webkit-reviews] review granted: [Bug 129074] [UI-Side Compositing] 6% of main thread time spent copying LayerProperties when adding to hash table : [Attachment 224691] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129074: [UI-Side Compositing] 6% of main thread time spent copying
LayerProperties when adding to hash table
https://bugs.webkit.org/show_bug.cgi?id=129074

Attachment 224691: Patch
https://bugs.webkit.org/attachment.cgi?id=224691&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224691&action=review


> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:214
>      if (changedProperties & BackingStoreChanged) {
> -	   encoder << backingStore.hasFrontBuffer();
> -	   if (backingStore.hasFrontBuffer())
> -	       encoder << backingStore;
> +	   encoder << backingStore->hasFrontBuffer();
> +	   if (backingStore->hasFrontBuffer())
> +	       encoder << *backingStore;
>      }

What if BackingStoreChanged because it went away?? I guess we'll still have
one, it'll just be one that doesn't paint.