[webkit-reviews] review granted: [Bug 128967] Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons : [Attachment 224673] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 19 16:12:57 PST 2014
Andreas Kling <akling at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128967: Move to using std::unique_ptr for VisitedLinkState,
CheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=128967
Attachment 224673: Patch
https://bugs.webkit.org/attachment.cgi?id=224673&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224673&action=review
r=me
> Source/WebCore/dom/CheckedRadioButtons.cpp:189
> + std::unique_ptr<RadioButtonGroup>& group =
m_nameToGroupMap->add(element->name().impl(), nullptr).iterator->value;
I'd use "auto&" here.
More information about the webkit-reviews
mailing list