[webkit-reviews] review granted: [Bug 129068] fieldset:disabled > legend:first-child legend input should not be disabled : [Attachment 224688] Fixes the bug

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 129068: fieldset:disabled > legend:first-child legend input should not be
disabled
https://bugs.webkit.org/show_bug.cgi?id=129068

Attachment 224688: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=224688&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224688&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   An input element inside a disabled fieldset element is ordinarily
disabled unless it's inside
> +	   a legend element that is the first of its kind to appear in the
fieldset's child node list.

It would be interesting to note what other engines do in this scenario.

> Source/WebCore/ChangeLog:11
> +	   Prior to this pach, an input element inside such a legend element
was erroneously disabled if

patch

> Source/WebCore/html/HTMLFormControlElement.cpp:104
> +    Element* previousAncestor = 0;

nullptr

> Source/WebCore/html/HTMLFormControlElement.cpp:106
>	   if (ancestor->hasTagName(fieldsetTag)) {

isHTMLFieldSetElement(ancestor)

> Source/WebCore/html/HTMLFormControlElement.cpp:107
> +	       HTMLFieldSetElement* fieldSetAncestor =
toHTMLFieldSetElement(ancestor);

I would make this a reference.

> Source/WebCore/html/HTMLFormControlElement.cpp:108
> +	       bool isInFirstLegend = previousAncestor &&
previousAncestor->hasTagName(legendTag) && previousAncestor ==
fieldSetAncestor->legend();

isHTMLLegendElement(previousAncestor)