[webkit-reviews] review granted: [Bug 128564] WK2 AVKit fullscreen doesn't display video. : [Attachment 224684] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128564: WK2 AVKit fullscreen doesn't display video.
https://bugs.webkit.org/show_bug.cgi?id=128564

Attachment 224684: Patch
https://bugs.webkit.org/attachment.cgi?id=224684&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224684&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:305
> +    else if (videoLayer)
> +    {

Brace on previous line.

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:190
> +    Vector<WebCore::GraphicsLayer::PlatformLayerID>
m_unparentedVideoLayerIDs;

This could be a HashSet.

It's not clear why the "unparented" is important here. Maybe
isVideoLayersPendingFullscreen or something?

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:405
> +    for (auto layerID : result.m_unparentedVideoLayerIDs) {
> +	   if (!layerID)
> +	       return false;
> +    }

Not sure why you need this check.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.cpp:71
> +    RemoteLayerTreeDrawingAreaProxy* remoteDrawingAreaProxy =
toRemoteLayerTreeDrawingAreaProxy(drawingAreaProxy);

toRemoteLayerTreeDrawingAreaProxy(m_page->drawingArea()) and remove the
previous line.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:67
> +    bool m_enterFullscreenAfterVideoLayerUnparentedTransaction;
> +    WebCore::GraphicsLayer::PlatformLayerID m_videoLayerID;

Both these should be initialized in the constructor.

> Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h:81
> +    RefPtr<WebCore::PlatformCALayer> m_platformCALayer;
> +    bool m_sendUnparentVideoLayerTransaction;

Also need initializing in the constructor.