[webkit-reviews] review granted: [Bug 129066] FTL should allow LLVM to allocate data sections with alignment > 8 : [Attachment 224682] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129066: FTL should allow LLVM to allocate data sections with alignment > 8
https://bugs.webkit.org/show_bug.cgi?id=129066

Attachment 224682: the patch
https://bugs.webkit.org/attachment.cgi?id=224682&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224682&action=review


r=me

> Source/JavaScriptCore/ftl/FTLDataSection.cpp:51
> +    m_base = bitwise_cast<void*>(
> +	   (bitwise_cast<uintptr_t>(m_allocationBase) + alignment - 1) &
~static_cast<uintptr_t>(alignment - 1));
> +    

Can we use roundUpToMultipleOf<> here?