[webkit-reviews] review denied: [Bug 124999] [Texmap] TextureMapperLayer unnecessary object copying : [Attachment 218041] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 19 12:28:06 PST 2014
Brent Fulgham <bfulgham at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 124999: [Texmap] TextureMapperLayer unnecessary object copying
https://bugs.webkit.org/show_bug.cgi?id=124999
Attachment 218041: patch
https://bugs.webkit.org/attachment.cgi?id=218041&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218041&action=review
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:348
> for (size_t i = 0; i < rects.size(); ++i) {
Please make this a C++11 loop.
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:369
> + const IntRect& rect = rects[i];
Ditto.
More information about the webkit-reviews
mailing list