[webkit-reviews] review denied: [Bug 129052] [JS] Convert Promise.prototype.catch to be a built-in : [Attachment 224656] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 12:18:47 PST 2014

Geoffrey Garen <ggaren at apple.com> has denied Sam Weinig <sam at webkit.org>'s
request for review:
Bug 129052: [JS] Convert Promise.prototype.catch to be a built-in

Attachment 224656: Patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224656&action=review

> Source/JavaScriptCore/builtins/Promise.prototype.js:33
> +    var then = this.then;
> +    if (typeof then !== "function")
> +	   throw new @TypeError("Promise.prototype.catch requires that
|onRejected| be a function");
> +
> +    return then. at call(this, undefined, onRejected);

return this.then(undefined, onRejected);

More information about the webkit-reviews mailing list