[webkit-reviews] review granted: [Bug 129051] GetMyArgumentsByLength in FTL doesn't work with inline code : [Attachment 224654] Fixed GetMyArgumentsLength in FTL to work with inline code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 11:59:06 PST 2014


Geoffrey Garen <ggaren at apple.com> has granted Matthew Mirman
<mmirman at apple.com>'s request for review:
Bug 129051: GetMyArgumentsByLength in FTL doesn't work with inline code
https://bugs.webkit.org/show_bug.cgi?id=129051

Attachment 224654: Fixed GetMyArgumentsLength in FTL to work with inline code
https://bugs.webkit.org/attachment.cgi?id=224654&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
dfgShouldBe is a slightly better way to write a test like this. It tests
precisely whether the function made it into our optimizing compilers, which
means the test can terminate sooner, and there's no risk that the test will
terminate too soon. You should make that change in a follow-up patch.


More information about the webkit-reviews mailing list