[webkit-reviews] review granted: [Bug 129021] StyleResolver::loadPendingImage() should take a reference to StylePendingImage : [Attachment 224580] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 11:00:48 PST 2014


Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 129021: StyleResolver::loadPendingImage() should take a reference to
StylePendingImage
https://bugs.webkit.org/show_bug.cgi?id=129021

Attachment 224580: Patch v1
https://bugs.webkit.org/attachment.cgi?id=224580&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224580&action=review


r=me

> Source/WebCore/css/StyleResolver.cpp:3495
> +    if (CSSImageSetValue* imageSetValue = pendingImage.cssImageSetValue())

Shouldn't this just be 'auto imageSetValue', too?


More information about the webkit-reviews mailing list