[webkit-reviews] review requested: [Bug 128740] ASSERTION FAILED: (year >= 1970 && yearday >= 0) || (year < 1970 && yearday < 0) in WTF::dateToDaysFrom1970 : [Attachment 224648] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 10:10:08 PST 2014


Dániel Bátyai <dbatyai.u-szeged at partner.samsung.com> has asked	for review:
Bug 128740: ASSERTION FAILED: (year >= 1970 && yearday >= 0) || (year < 1970 &&
yearday < 0) in WTF::dateToDaysFrom1970
https://bugs.webkit.org/show_bug.cgi?id=128740

Attachment 224648: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=224648&action=review

------- Additional Comments from Dániel Bátyai
<dbatyai.u-szeged at partner.samsung.com>
Very large numbers could cause an overflow which resulted in the assertion
failing in WTF::dateToDaysFrom1970
The patch makes DateConstructor check if the number fits into an Int32 before
casting


More information about the webkit-reviews mailing list