[webkit-reviews] review denied: [Bug 129023] Correctly install libllvmForJSC.dylib in production builds : [Attachment 224585] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 21:18:23 PST 2014


Mark Rowe (bdash) <mrowe at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129023: Correctly install libllvmForJSC.dylib in production builds
https://bugs.webkit.org/show_bug.cgi?id=129023

Attachment 224585: the patch
https://bugs.webkit.org/attachment.cgi?id=224585&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224585&action=review


> Source/JavaScriptCore/Configurations/Base.xcconfig:111
> +JAVASCRIPTCORE_LIBRARIES_DIR_macosx =
JavaScriptCore.framework/Versions/A/Resources;

This isn't the right path.

I'd suggest pulling out a JAVASCRIPTCORE_CONTENTS_DIR variable that's
JavaScriptCore.framework on iOS and JavaScriptCore.framework/Versions/A on OS
X, then just defining JAVASCRIPTCORE_RESOURCES_DIR =
$(JAVASCRIPTCORE_CONTENTS_DIR)/Resources and JAVASCRIPTCORE_LIBRARIES_DIR =
$(JAVASCRIPTCORE_CONTENTS_DIR)/Libraries/. We don't need to repeat the
conditionals twice.


More information about the webkit-reviews mailing list